official
/
OpenLCP
1
0
Fork 0
Code Releases 1 Activity

Clang -Wall -Wextra cleanups

This commit is contained in:
Kevin Matz 2021-08-02 10:10:55 -04:00
parent 4ce0bf73ea
commit c01cd08b86
10 changed files with 25 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
acn/appliance.cpp
View File

@ -168,7 +168,7 @@ void Appliance::RlpDerigsterVector()
* @brief Appliance::SdtReceiver
* @param rlp
*/
void Appliance::SdtReceiver(std::shared_ptr<RLP::Pdu> rlp)
void Appliance::SdtReceiver(__attribute__((unused)) std::shared_ptr<RLP::Pdu> rlp)
{
/// TODO: handle SDT
}
@ -178,7 +178,7 @@ void Appliance::SdtReceiver(std::shared_ptr<RLP::Pdu> rlp)
* @brief Appliance::DmpReceiver
* @param rlp
*/
void Appliance::DmpReceiver(std::shared_ptr<RLP::Pdu> rlp)
void Appliance::DmpReceiver(__attribute__((unused)) std::shared_ptr<RLP::Pdu> rlp)
{
/// TODO: DMP in root
}

6
acn/component.h
View File

@ -38,9 +38,9 @@ namespace ACN {
class Component {
public:
Component(UUID::uuid cid = UUID::uuid())
: cid_(cid)
, fctn_(std::string("libESTA ACN Component"))
, uacn_(std::string())
: fctn_(std::string("libESTA ACN Component"))
, uacn_(std::string())
, cid_(cid)
{};
const UUID::uuid cid() const { return cid_; }

6
acn/pdu.cpp
View File

@ -53,7 +53,7 @@ Pdu::~Pdu()
* @brief Pdu::vector
* @return
*/
const uint32_t Pdu::vector()
uint32_t Pdu::vector()
{
if (flags_.hasVector)
return vector_;
@ -172,7 +172,7 @@ void Pdu::iStream(Stream stream)
// length includes the flags, length, and vector.
// the remainder of the length of header and data
int hd_length = length - (flags_.hasLength ? 3 : 2) - vector_size_;
uint hd_length = length - (flags_.hasLength ? 3 : 2) - vector_size_;
// abort if the remaining PDU length isn't available
if (!stream->good() || stream->available() < hd_length) {
@ -188,7 +188,7 @@ void Pdu::iStream(Stream stream)
}
// fast-forward the input stream
for (int i = 0; i < hd_length; i++)
for (uint i = 0; i < hd_length; i++)
stream->get();
if (!stream->available())
stream->setstate(std::ios_base::eofbit);

2
acn/pdu.h
View File

@ -85,7 +85,7 @@ public:
~Pdu();
// getters
const uint32_t vector(); // may inherit
uint32_t vector(); // may inherit
pdu_header * header(); // may inherit
pdu_data * data(); // may inherit
std::shared_ptr<Pdu> parent() {return parent_;}

4
dmx/universe.cpp
View File

@ -50,7 +50,7 @@ Universe::~Universe()
@param uint16_t address of the requested slot.
@return const uint8_t value of the slot.
*/
const uint8_t Universe::slot (const uint16_t address) const
uint8_t Universe::slot(const uint16_t address) const
{
if (address == 0) return 0;
if (address > null_start_data_.size() - 1) return 0;
@ -65,7 +65,7 @@ const uint8_t Universe::slot (const uint16_t address) const
* Calculated as the rolling mean of (the number of frames in
* the last 2.5 seconds) / 2.5 seconds.
*/
const double Universe::rxRate()
double Universe::rxRate()
{
rx_timeout_();
return rx_times_.size() / 2.5;

6
platform/qt/qsacnuniverse.h
View File

@ -27,17 +27,17 @@ public:
return QString::fromUtf8(universe_->source()->description().c_str());
}
const uint16_t number() const
uint16_t number() const
{
return universe_->source()->universe();
}
const uint8_t priority() const
uint8_t priority() const
{
return universe_->source()->priority();
}
const double rxRate() const
double rxRate() const
{
return universe_->rxRate();
}

6
sacn/extended.cpp
View File

@ -58,7 +58,7 @@ void frame_sync_header::iStream(PDU::Stream stream)
* @brief frame_sync_header::oStream
* @return
*/
void frame_sync_header::oStream(PDU::Stream stream) const
void frame_sync_header::oStream(__attribute__((unused)) PDU::Stream stream) const
{
/// TODO: write header to stream
}
@ -94,7 +94,7 @@ void frame_discovery_header::iStream(PDU::Stream stream)
* @brief frame_discovery_header::oStream
* @return
*/
void frame_discovery_header::oStream(PDU::Stream stream) const
void frame_discovery_header::oStream(__attribute__((unused)) PDU::Stream stream) const
{
/// TODO: write header to stream
}
@ -162,7 +162,7 @@ void discovery_list_header::iStream(PDU::Stream stream)
* @brief discovery_list_header::oStream
* @return
*/
void discovery_list_header::oStream(PDU::Stream stream) const
void discovery_list_header::oStream(__attribute__((unused)) PDU::Stream stream) const
{
/// TODO: write header to stream
}

2
sacn/extended.h
View File

@ -104,7 +104,7 @@ public:
const UUID::uuid cid() const {return cid_;};
const std::string description() const {return description_;}
const uint16_t universe() const {return universe_;}
uint16_t universe() const {return universe_;}
private:
UUID::uuid cid_;

2
sacn/receiver.cpp
View File

@ -266,7 +266,7 @@ void Receiver::dataFrameHandler(std::shared_ptr<DATA::Pdu> frame) {
* @brief Receiver::syncFrameHandler
* @param frame
*/
void Receiver::syncFrameHandler(std::shared_ptr<EXTENDED::Pdu> frame)
void Receiver::syncFrameHandler(__attribute__((unused)) std::shared_ptr<EXTENDED::Pdu> frame)
{
/// TODO: Universe sync
}

12
sacn/universe.h
View File

@ -43,14 +43,14 @@ public:
const UUID::uuid CID() const {return cid_;};
const std::string description() const {return description_;}
const uint16_t universe() const {return universe_;}
const uint8_t priority() const {return priority_;}
const uint16_t syncAddress() const {return sync_address_;}
const bool isTerminated() const {return options_
uint16_t universe() const {return universe_;}
uint8_t priority() const {return priority_;}
uint16_t syncAddress() const {return sync_address_;}
bool isTerminated() const {return options_
& DATA::STREAM_TERMINATED;}
const bool isPreview() const {return options_
bool isPreview() const {return options_
& DATA::PREVIEW_DATA;}
const bool isForced() const {return options_
bool isForced() const {return options_
& DATA::FORCE_SYNCHRONIZATION;}
friend bool operator== (const UniverseSource& a, const UniverseSource& b);