official
/
OpenLCP
1
0
Fork 0
Code Releases 1 Activity

document behavior that is non-standard

This commit is contained in:
Kevin Matz 2021-09-02 13:21:11 -04:00
parent 79be37d38a
commit 7f0919f60c
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
protocols/sacn/receiver.cpp
View File

@ -209,6 +209,7 @@ void Receiver::dataFrameHandler(ACN::PDU::Message<DATA::Pdu> frame) {
/// > This bit, when set to 1, indicates that the data in this packet is
/// > intended for use in visualization or media server preview applications
/// > and shall not be used to generate live output.
/// \bug Preview_Data flag is ignored
if (source->options.preview_data)
return;
@ -239,8 +240,8 @@ void Receiver::dataFrameHandler(ACN::PDU::Message<DATA::Pdu> frame) {
/// > then the packet containing sequence number B shall be deemed out of
/// > sequence and discarded.
/// \bug The standard requires that transmitters send incrimenting sequence
/// numbers, but many sources do not. By tolerating out-of-spec sources
/// transmitting 0s instead of a sequence number, the receiver must operate
/// numbers, but some sources may not. By tolerating out-of-spec sources
/// transmitting 0s instead of a sequence number, the receiver may operate
/// in a mode where it cannnot detect missing or out-of-sequence packets.
auto a = universe->provenance()->sequence_number;
auto b = source->sequence_number;