official/OpenLCP
1
0
Fork 0
Code Releases 1 Activity

correctly scale return value, with comment about linearity

Browse Source
This commit is contained in:
Kevin Matz 2023-03-30 20:14:59 -04:00
parent cd884a8593
commit 6cd9a9e6df
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
protocol/esta/analog/receiver.h
View File

@ -45,16 +45,15 @@ struct Receiver
/** /**
* @brief Convert millivolts to an 8-bit level. * @brief Convert millivolts to an 8-bit level.
* @param mV * @param mV
* @return * @return \cite ANALOG 5.4 Scale: control is intended to be linear
*/ */
uint8_t level(const int16_t mV) const uint8_t level(const int16_t mV) const
{ {
if (mV <= zero) if (mV <= zero)
return 0; return 0;
else if ( mV >= full) if ( mV >= full)
return UINT8_MAX; return UINT8_MAX;
else return UINT8_MAX * ((mV - zero) / (full - zero));
return (mV - zero) / (full - zero);
} }
/** /**