explicit constructors and virtual destructors

platform/qt/qsacnnode.h

@@ -23,7 +23,7 @@ public:
     explicit QSacnNode(QObject *parent = nullptr,
                        QUuid = QUuid::createUuid(), QString fctn = "OpenLCP QSacnNode",
                        bool ipv4 = true, bool ipv6 = true);
-    ~QSacnNode();
+    virtual ~QSacnNode();
 
     // sACN::RLP::Component
     void sendUDP(const ACN::PDU::Stream, const ACN::SDT::UDP::ipAddress&) const override;

protocol/esta/acn/component.h

@@ -51,7 +51,7 @@ public:
    * @param cid
    * @param fctn
    */
-  Component(UUID::uuid cid = UUID::uuid(), std::string fctn = "OpenLCP ACN Component")
+  explicit Component(UUID::uuid cid = UUID::uuid(), std::string fctn = "OpenLCP ACN Component")
     : cid_(cid)
     , fctn_(fctn)
     , uacn_(std::string())

protocol/esta/acn/dmp/appliance.h

@@ -40,7 +40,7 @@ class Appliance
     , public DMP::Component
 {
 public:
-  Appliance(UUID::uuid = UUID::uuid(), std::string fctn = "OpenLCP DMP Appliance");
+  explicit Appliance(UUID::uuid = UUID::uuid(), std::string fctn = "OpenLCP DMP Appliance");
 
   virtual void RlpReceiver(PDU::Message<RLP::Pdu>);
 };

protocol/esta/acn/dmp/component.h

@@ -49,7 +49,7 @@ class Component
   : public virtual ACN::Component
 {
 public:
-  Component(UUID::uuid = UUID::uuid(), std::string fctn = "OpenLCP DMP Component");
+  explicit Component(UUID::uuid = UUID::uuid(), std::string fctn = "OpenLCP DMP Component");
 
   void addDmpSender(PDU::Handler<DMP::Pdu>);
   void DmpReceiver(std::shared_ptr<ACN::PDU::Block<DMP::Pdu>>);

protocol/esta/acn/dmp/controller.h

@@ -34,7 +34,7 @@ class Controller
     : public virtual DMP::Component
 {
 public:
-  Controller(UUID::uuid = UUID::uuid(), std::string fctn = "OpenLCP DMP Controller");
+  explicit Controller(UUID::uuid = UUID::uuid(), std::string fctn = "OpenLCP DMP Controller");
 };
 
 } // namespace ACN::DMP

protocol/esta/acn/dmp/device.h

@@ -37,8 +37,8 @@ class Device
   : public virtual DMP::Component
 {
 public:
-  Device(UUID::uuid = UUID::uuid(), std::string fctn = "OpenLCP DMP Device");
+  explicit Device(UUID::uuid = UUID::uuid(), std::string fctn = "OpenLCP DMP Device");
-  ~Device();
+  virtual ~Device();
 
 protected:
   virtual void rxDmpGetProperty(PDU::Message<DMP::Pdu>) override;

protocol/esta/acn/dmp/event.h

@@ -31,7 +31,7 @@ namespace ACN::DMP {
 class Event
 {
 public:
-  Event();
+  explicit Event();
 };
 
 } // namespace ACN::DMP

protocol/esta/acn/rlp/component.h

@@ -46,7 +46,7 @@ class Component
   : public ACN::Component
 {
 public:
-  Component(UUID::uuid = UUID::uuid(), std::string fctn = "OpenLCP RLP Component",
+  explicit Component(UUID::uuid = UUID::uuid(), std::string fctn = "OpenLCP RLP Component",
                      bool ipv4 = true, bool ipv6 = true);
 
   /// \brief Set the IPv4 enabled state

protocol/esta/acn/sdt/channel.h

@@ -47,8 +47,8 @@ enum Direction {
  */
 class Channel {
 public:
-  Channel(std::shared_ptr<ACN::RLP::Component>, Direction);
+  explicit Channel(std::shared_ptr<ACN::RLP::Component>, Direction);
-  ~Channel();
+  virtual ~Channel();
 
 private:
   std::shared_ptr<ACN::RLP::Component> owner_;

protocol/esta/acn/sdt/identity.h

@@ -31,7 +31,7 @@ namespace ACN::SDT {
 class Identity
 {
 public:
-  Identity();
+  explicit Identity();
 };
 
 } // namespace ACN::SDT

protocol/esta/acn/sdt/leader.h

@@ -38,7 +38,7 @@ class Leader
     : public ACN::RLP::Component
 {
 public:
-  Leader(UUID::uuid = UUID::uuid(), std::string fctn = "OpenLCP SDT Leader");
+  explicit Leader(UUID::uuid = UUID::uuid(), std::string fctn = "OpenLCP SDT Leader");
 
   // RLP->SDT frames
   virtual void SdtReceiver(PDU::Message<RLP::Pdu>);

protocol/esta/acn/sdt/member.h

@@ -34,7 +34,7 @@ class Member
     : public ACN::RLP::Component
 {
 public:
-  Member(UUID::uuid = UUID::uuid(), std::string fctn = "OpenLCP SDT Member");
+  explicit Member(UUID::uuid = UUID::uuid(), std::string fctn = "OpenLCP SDT Member");
 
   virtual void SdtReceiver(PDU::Message<RLP::Pdu>);
 };

protocol/esta/acn/sdt/session.h

@@ -50,8 +50,8 @@ struct SessionId {
  */
 class Session {
 public:
-  Session();
+  explicit Session();
-  ~Session();
+  virtual ~Session();
 
   SessionId id();
 

protocol/esta/dmx/device.h

@@ -36,7 +36,7 @@ namespace DMX {
 class Device
 {
 public:
-  Device();
+  explicit Device();
   virtual ~Device();
 
   uint16_t footprint() const;

protocol/esta/dmx/patch.h

@@ -31,7 +31,7 @@ namespace DMX {
 class Patch
 {
 public:
-  Patch();
+  explicit Patch();
 };
 
 } // namespace DMX

protocol/esta/dmx/personality.h

@@ -34,7 +34,7 @@ namespace DMX {
 class Personality
 {
 public:
-  Personality();
+  explicit Personality();
   virtual ~Personality();
 
   uint16_t footprint() const;

protocol/esta/dmx/universe.h

@@ -46,7 +46,7 @@ using DimmerData = std::array<uint8_t, E111_LAST_SLOT + 1>;  //!< Array of 513 b
  */
 class Universe {
   public:
-    Universe (int timeout_period = E111_DATA_LOSS_TIMEOUT);
+    explicit Universe (int timeout_period = E111_DATA_LOSS_TIMEOUT);
 
     virtual long age();
     virtual double rxRate();

protocol/esta/rdm/controller.h

@@ -35,8 +35,8 @@ namespace RDM {
 class Controller
 {
 public:
-  Controller();
+  explicit Controller();
-  ~Controller();
+  virtual ~Controller();
 
   bool findDevices(uint64_t lowerBound = 0,
                    uint64_t upperBound = 0xFFFFFFFFFFFE) const;

protocol/esta/rdm/device.h

@@ -44,7 +44,7 @@ class Device
     : public DMX::Device
 {
 public:
-  Device(UID id = UID(), Device* parent = nullptr);
+  explicit Device(UID id = UID(), Device* parent = nullptr);
   virtual ~Device();
 
   void addSubDevice(uint16_t number, Device* dev);

protocol/esta/rdm/message.h

@@ -41,9 +41,9 @@ using MsgPtr = std::shared_ptr<Message>; //!< valid RDM Message
  */
 struct Message
 {
-  Message();
+  explicit Message();
-  Message(const Message &obj);
+  explicit Message(const Message &obj);
-  Message(const std::vector<uint8_t> &data);
+  explicit Message(const std::vector<uint8_t> &data);
 
   void read(const std::vector<uint8_t> &data);
   void write(std::vector<uint8_t> &data) const;

protocol/esta/rdm/parameter.h

@@ -42,8 +42,8 @@ using PidAction = std::function<void(const MsgPtr message, MsgPtr response)>;
 class Parameter
 {
 public:
-  Parameter();
+  explicit Parameter();
-  ~Parameter();
+  virtual ~Parameter();
 
   void disc(const MsgPtr message, MsgPtr response) const;
   void get(const MsgPtr message, MsgPtr response) const;

protocol/esta/rdm/responder.h

@@ -37,7 +37,7 @@ class Responder
     : public Device
 {
 public:
-  Responder(UID id, Device* parent = nullptr);
+  explicit Responder(UID id, Device* parent = nullptr);
   virtual ~Responder();
 
   union {

protocol/esta/rdm/sensor.h

@@ -36,7 +36,7 @@ namespace RDM {
 class Sensor
 {
 public:
-  Sensor();
+  explicit Sensor();
   virtual ~Sensor() {};
 
   // RDM required properties

protocol/esta/rdmnet/broker.h

@@ -38,7 +38,7 @@ class Broker
     , public RPT::Broker
 {
 public:
-  Broker(UUID::uuid = UUID::uuid(), std::string ftcn = "OpenLCP RDMnet Broker",
+  explicit Broker(UUID::uuid = UUID::uuid(), std::string ftcn = "OpenLCP RDMnet Broker",
                   RDM::UID = RDM::UID());
 
   void rlpBrokerReceiver(ACN::PDU::Message<ACN::RLP::Pdu>);

protocol/esta/rdmnet/controller.h

@@ -38,7 +38,7 @@ class Controller
     , public RPT::Controller
 {
 public:
-  Controller(UUID::uuid = UUID::uuid(), std::string fctn = "OpenLCP RDMnet Controller",
+  explicit Controller(UUID::uuid = UUID::uuid(), std::string fctn = "OpenLCP RDMnet Controller",
                       RDM::UID = RDM::UID());
 
   void rlpRptReceiver(ACN::PDU::Message<ACN::RLP::Pdu>);

protocol/esta/rdmnet/device.h

@@ -36,7 +36,7 @@ class Device
     , public RPT::Device
 {
 public:
-  Device(UUID::uuid cid = UUID::uuid(), std::string fctn = "OpenLCP RDMnet Device",
+  explicit Device(UUID::uuid cid = UUID::uuid(), std::string fctn = "OpenLCP RDMnet Device",
                   RDM::UID uid = RDM::UID(), UUID::uuid rid = UUID::uuid());
 
   void rlpRptReceiver(ACN::PDU::Message<ACN::RLP::Pdu>);

protocol/esta/rdmnet/ept/broker.h

@@ -32,7 +32,7 @@ namespace RDMnet::EPT {
 class Broker
 {
 public:
-  Broker();
+  explicit Broker();
 };
 
 } // namespace RDMnet::EPT

protocol/esta/rdmnet/ept/client.h

@@ -33,7 +33,7 @@ namespace RDMnet::EPT {
 class Client
 {
 public:
-  Client();
+  explicit Client();
 
   /**
    * @brief receiveEPT

protocol/esta/rdmnet/implementation.h

@@ -40,7 +40,8 @@ class Implementation
   , public EPT::Client
 {
 public:
-  Implementation(UUID::uuid = UUID::uuid(), std::string fctn = "OpenLCP RDMnet Implementation",
+  explicit Implementation(UUID::uuid = UUID::uuid(),
+                          std::string fctn = "OpenLCP RDMnet Implementation",
                           RDM::UID = RDM::UID());
 
 protected:

protocol/esta/rdmnet/llrp/manager.h

@@ -24,7 +24,7 @@
 #pragma once
 
 #include "llrp.h"
-#include "component.h"
+#include "rlp/component.h"
 
 namespace RDMnet::LLRP {
 
@@ -38,7 +38,7 @@ class Manager
     : public ACN::RLP::Component
 {
 public:
-  Manager(UUID::uuid = UUID::uuid(), std::string fctn = "OpenLCP LLRP Manager");
+  explicit Manager(UUID::uuid = UUID::uuid(), std::string fctn = "OpenLCP LLRP Manager");
 
   void rlpLlrpReceiver(ACN::PDU::Message<ACN::RLP::Pdu>);
 

protocol/esta/rdmnet/llrp/target.h

@@ -37,7 +37,7 @@ namespace RDMnet::LLRP {
 class Target
 {
 public:
-  Target();
+  explicit Target();
 
   virtual void LLRPsetup() = 0; //!< listens on LLRP_PORT
 

protocol/esta/rdmnet/rpt/broker.h

@@ -31,7 +31,7 @@ namespace RDMnet::RPT {
 class Broker
 {
 public:
-  Broker();
+  explicit Broker();
 };
 
 } // namespace RDMnet::RPT

protocol/esta/rdmnet/rpt/controller.h

@@ -31,7 +31,7 @@ namespace RDMnet::RPT {
 class Controller
 {
 public:
-  Controller();
+  explicit Controller();
 };
 
 } // namespace RDMnet::RPT

protocol/esta/rdmnet/rpt/device.h

@@ -31,7 +31,7 @@ namespace RDMnet::RPT {
 class Device
 {
 public:
-  Device();
+  explicit Device();
 
 protected:
   bool connectedToBroker; ///< True if the device is connected to a broker.

protocol/esta/sacn/arbitratinguniverse.cpp

@@ -39,14 +39,6 @@ ArbitratingUniverse::ArbitratingUniverse()
 }
 
 
-/**
- * @brief ArbitratingUniverse::~MergeProxyUniverse
- */
-ArbitratingUniverse::~ArbitratingUniverse()
-{
-}
-
-
 /**
  * @brief ArbitratingUniverse::setHoldLastLook
  * @param state

protocol/esta/sacn/arbitratinguniverse.h

@@ -55,8 +55,7 @@ class ArbitratingUniverse
   : public sACN::Universe
 {
 public:
-    ArbitratingUniverse();
+    explicit ArbitratingUniverse();
-    ~ArbitratingUniverse();
 
     uint16_t expectedUniverse; ///< Expected universe number
 

protocol/esta/sacn/node.h

@@ -36,7 +36,7 @@ class Node
     , public Source
 {
 public:
-    Node(UUID::uuid = UUID::uuid(), std::string fctn = "OpenLCP sACN Node");
+    explicit Node(UUID::uuid = UUID::uuid(), std::string fctn = "OpenLCP sACN Node");
 };
 
 } // SACN

protocol/esta/sacn/receiver.h

@@ -65,8 +65,8 @@ class Receiver
   : public virtual ACN::RLP::Component
 {
 public:
-  Receiver(UUID::uuid = UUID::uuid(), std::string fctn = "OpenLCP sACN Receiver");
+  explicit Receiver(UUID::uuid = UUID::uuid(), std::string fctn = "OpenLCP sACN Receiver");
-  ~Receiver();
+  virtual ~Receiver();
 
   virtual void subscribe(const uint16_t);
   virtual void unsubscribe(const uint16_t);

protocol/esta/sacn/source.h

@@ -47,8 +47,8 @@ class Source
     : public virtual ACN::RLP::Component
 {
 public:
-    Source(UUID::uuid = UUID::uuid(), std::string fctn = "OpenLCP sACN Source");
+    explicit Source(UUID::uuid = UUID::uuid(), std::string fctn = "OpenLCP sACN Source");
-    ~Source();
+    virtual ~Source();
 
     virtual void create(const uint16_t);
     virtual void terminate(const uint16_t);

protocol/esta/sacn/universe.h

@@ -46,8 +46,8 @@ class Universe
     , public std::enable_shared_from_this<Universe>
 {
 public:
-  Universe(Source* = nullptr);
+  explicit Universe(Source* = nullptr);
-  ~Universe();
+  virtual ~Universe();
 
   friend class UniverseSender;