diff --git a/acn/appliance.cpp b/acn/appliance.cpp index 70d2699..a17bf63 100644 --- a/acn/appliance.cpp +++ b/acn/appliance.cpp @@ -67,7 +67,7 @@ void Appliance::UdpStreamHandler(PDU::Stream stream) { if (stream->fail()) return; - for(auto root : *block) { + for(auto const &root : *block) { RlpReceiver(root); } } @@ -91,7 +91,7 @@ void Appliance::TcpStreamHandler(PDU::Stream stream) { if (stream->fail()) return; - for(auto root : *block) { + for(auto const &root : *block) { RlpReceiver(root); } } @@ -103,7 +103,7 @@ void Appliance::TcpStreamHandler(PDU::Stream stream) { void Appliance::RlpReceiver(std::shared_ptr root) { if (!rlp_vectors_.count(root->vector())) return; - for(auto handler : rlp_vectors_[root->vector()]) { + for(auto const &handler : rlp_vectors_[root->vector()]) { handler(root); } } diff --git a/acn/dmp.cpp b/acn/dmp.cpp index acbf946..5bdd238 100644 --- a/acn/dmp.cpp +++ b/acn/dmp.cpp @@ -35,7 +35,10 @@ address_type::address_type(uint8_t val) { width = (address_length)(val & 0b11); } -range::range(PDU::Stream stream, data_type t, address_length l) { +range::range(PDU::Stream stream, data_type t, address_length l) : + incriment(0), + count(0) +{ address = read(stream, l); if (t == SINGLE) return; incriment = read(stream, l); diff --git a/sacn/receiver.cpp b/sacn/receiver.cpp index e613bac..52b6ac1 100644 --- a/sacn/receiver.cpp +++ b/sacn/receiver.cpp @@ -66,7 +66,7 @@ void Receiver::rootDataHandler(std::shared_ptr root) { auto block = PDU::readBlock(root->buffer(), root); if (root->buffer()->fail()) return; - for(auto frame : *block) { + for(auto const &frame : *block) { // 6.2.1 E1.31 Data Packet: Vector // Sources sending an E1.31 Data Packet shall set the E1.31 Layer's Vector // to VECTOR_E131_DATA_PACKET. This value indicates that the E1.31 framing @@ -160,7 +160,7 @@ void Receiver::dataPacketHandler(std::shared_ptr frame) { auto block = PDU::readBlock(frame->buffer(), frame); if (frame->buffer()->fail()) return; - for (auto dmp : *block) { + for (auto const &dmp : *block) { // 7.2 DMP Layer: Vector // The DMP Layer's Vector shall be set to VECTOR_DMP_SET_PROPERTY, which // indicates a DMP Set Property message by sources. Receivers shall discard