From 0e2b2ce039b9851f093ccdbbf982965f72a5c494 Mon Sep 17 00:00:00 2001 From: Kevin Matz Date: Sun, 4 Dec 2022 11:53:48 -0500 Subject: [PATCH] rename methods for consistency --- example/sACN Explorer/multiversewindow.cpp | 20 ++++++++++---------- example/sACN Explorer/multiversewindow.h | 8 ++++---- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/example/sACN Explorer/multiversewindow.cpp b/example/sACN Explorer/multiversewindow.cpp index f23a255..d885fdf 100644 --- a/example/sACN Explorer/multiversewindow.cpp +++ b/example/sACN Explorer/multiversewindow.cpp @@ -44,13 +44,13 @@ MultiverseWindow::MultiverseWindow(QWidget *parent, QSacnNode *node) this, &MultiverseWindow::selectionChanged); connect(ui->multiverseView, &QTreeView::customContextMenuRequested, - this, &MultiverseWindow::createContextMenu); + this, &MultiverseWindow::openContextMenu); connect(ui->multiverseView, &QTreeView::doubleClicked, - this, &MultiverseWindow::createEditor); + this, &MultiverseWindow::openUniverseEditor); connect(ui->actionUACN, &QAction::triggered, - this, &MultiverseWindow::showUacnEditor); + this, &MultiverseWindow::openUacnEditor); connect(ui->actionIPv4, &QAction::toggled, node, &QSacnNode::setIPv4); @@ -61,7 +61,7 @@ MultiverseWindow::MultiverseWindow(QWidget *parent, QSacnNode *node) connect(ui->actionInspect, &QAction::triggered, this, [this]() { auto selected = ui->multiverseView->currentIndex(); - createEditor(selected); + openUniverseEditor(selected); }); connect(ui->actionCreate, &QAction::triggered, @@ -163,10 +163,10 @@ void MultiverseWindow::selectionChanged(const QModelIndex ¤t, /** - * @brief MultiverseWindow::multiverseContextMenu + * @brief MultiverseWindow::openContextMenu * @param pos */ -void MultiverseWindow::createContextMenu(const QPoint &pos) +void MultiverseWindow::openContextMenu(const QPoint &pos) { auto menu = new QMenu(ui->multiverseView); menu->setAttribute(Qt::WA_DeleteOnClose, true); @@ -201,10 +201,10 @@ void MultiverseWindow::createContextMenu(const QPoint &pos) /** - * @brief MultiverseWindow::createEditor + * @brief MultiverseWindow::openUniverseEditor * @param index */ -void MultiverseWindow::createEditor(const QModelIndex &index) +void MultiverseWindow::openUniverseEditor(const QModelIndex &index) { auto data = index.data(Qt::EditRole); @@ -241,9 +241,9 @@ void MultiverseWindow::createEditor(const QModelIndex &index) /** - * @brief MultiverseWindow::showUacnEditor + * @brief MultiverseWindow::openUacnEditor */ -void MultiverseWindow::showUacnEditor() +void MultiverseWindow::openUacnEditor() { auto editor = new LineEditDialog(this, "Name", 63, node->userName().c_str(), node->fixedName().c_str()); diff --git a/example/sACN Explorer/multiversewindow.h b/example/sACN Explorer/multiversewindow.h index 3e560dc..7e04804 100644 --- a/example/sACN Explorer/multiversewindow.h +++ b/example/sACN Explorer/multiversewindow.h @@ -51,11 +51,11 @@ public: QSacnNode* node = nullptr); virtual ~MultiverseWindow(); -public slots: +private slots: void selectionChanged(const QModelIndex ¤t, const QModelIndex &previous); - void createContextMenu(const QPoint &pos); - void createEditor(const QModelIndex &index); - void showUacnEditor(); + void openContextMenu(const QPoint &pos); + void openUniverseEditor(const QModelIndex &index); + void openUacnEditor(); private: Ui::MultiverseWindow *ui;